Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry Logic Fails to Retry Server Errors #2573

Closed
tustvold opened this issue Aug 24, 2022 · 0 comments · Fixed by #2574
Closed

Retry Logic Fails to Retry Server Errors #2573

tustvold opened this issue Aug 24, 2022 · 0 comments · Fixed by #2574
Assignees
@tustvold
Labels
bug object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Describe the bug

The logic in send_retry only retries errors returned by send which critically does not include errors due to reponse status.

To Reproduce

Expected behavior

Additional context
@tustvold tustvold added the bug label Aug 24, 2022
@tustvold tustvold self-assigned this Aug 24, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 24, 2022
@tustvold
Fix retry logic (apache#2573) (apache#2572)
9b2ae87
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 24, 2022
@tustvold
Fix retry logic (apache#2573) (apache#2572)
5ffbe56
@tustvold tustvold mentioned this issue Aug 24, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 24, 2022
@tustvold
Fix retry logic (apache#2573) (apache#2572)
2218ee3
tustvold added a commit that referenced this issue Aug 25, 2022
@tustvold
Fix retry logic (#2573) (#2572) (#2574)
8eea918 
* Fix retry logic (#2573) (#2572)

* Fix logical conflicts

* Rework tests
@alamb alamb added arrow Changes to the arrow crate object-store Object Store Interface and removed arrow Changes to the arrow crate labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
bug object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix retry logic (#2573) (#2572) tustvold/arrow-rs
2 participants
@alamb @tustvold