Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlightDataEncoder Optionally send Schema even when no record batches #3591

Closed
alamb opened this issue Jan 23, 2023 · 1 comment · Fixed by #3594
Closed

FlightDataEncoder Optionally send Schema even when no record batches #3591

alamb opened this issue Jan 23, 2023 · 1 comment · Fixed by #3594
Assignees
@alamb
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Jan 23, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We recently discovered in IOx that some Flight clients may return errors if no Schema message is sent, even if there are no RecordBatches (such as happens with an result set from a database)

Describe the solution you'd like
I would like a way to optionally configure FligthDataEncoder to always send a schema message, even if there are no record batches

Describe alternatives you've considered

Additional context
https://github.com/influxdata/influxdb_iox/pull/6668
@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow-flight Changes to the arrow-flight crate labels Jan 23, 2023
@alamb alamb self-assigned this Jan 23, 2023
@alamb
Copy link
Contributor Author

alamb commented Jan 23, 2023

I plan to contribute code for this feature shortly

@alamb alamb mentioned this issue Jan 24, 2023
Merged
@alamb alamb mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alamb alamb

Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support sending schemas for empty streams alamb/arrow-rs
1 participant
@alamb