Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add test for dictionary encoding of batches #3608

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 26, 2023

Which issue does this PR close?

re #3591
Adds another test for code added in #3594

Rationale for this change

We hit a bug (see https://github.com/influxdata/influxdb_iox/pull/6711) downstream in IOx due to the schema for empty stream being different than the schema for non empty stream -- I wanted to make sure this case was covered in arrow-rs

What changes are included in this PR?

Add a new test

Are there any user-facing changes?

no

@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Jan 26, 2023
@tustvold tustvold merged commit f9a78e0 into apache:master Jan 28, 2023
@ursabot
Copy link

ursabot commented Jan 28, 2023

Benchmark runs are scheduled for baseline = 8cc8327 and contender = f9a78e0. f9a78e0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants