Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Schema More Flexible Timestamp Inference #4131

Closed
tustvold opened this issue Apr 25, 2023 · 3 comments · Fixed by #4217
Closed

CSV Schema More Flexible Timestamp Inference #4131

tustvold opened this issue Apr 25, 2023 · 3 comments · Fixed by #4217
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The schema inference logic for CSV currently only infers timestamps matching the regex ^\d{4}-\d\d-\d\d[T ]\d\d:\d\d:\d\d.\d{1,9}$. This is significantly more restrictive than the parsing logic.

Describe the solution you'd like

Infer timestamp for all the types recognised by the parsing logic

Describe alternatives you've considered

Additional context

#3744 #4129

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2023
@tustvold tustvold self-assigned this Apr 25, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 15, 2023
@alamb
Copy link
Contributor

alamb commented May 17, 2023

Both #3744 #4129 are fixed -- I wonder if this ticket can also be closed

@tustvold
Copy link
Contributor Author

tustvold commented May 17, 2023

#4217 will close this, not sure why the link isn't showing up...

Edit: I typoed the ticket reference 🤦

@tustvold
Copy link
Contributor Author

tustvold commented Jun 2, 2023

label_issue.py automatically added labels {'arrow'} from #4217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants