Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type support for the python FFI bridge #477

Closed
kszucs opened this issue Jun 21, 2021 · 2 comments · Fixed by #3453
Closed

Improve type support for the python FFI bridge #477

kszucs opened this issue Jun 21, 2021 · 2 comments · Fixed by #3453
Labels
enhancement Any new improvement worthy of a entry in the changelog python

Comments

@kszucs
Copy link
Member

kszucs commented Jun 21, 2021

The current type support is partial, here is a list about the unsupported types:

unsupported_types = [
     pa.timestamp("us"),
     pa.timestamp("us", tz="UTC"),
     pa.timestamp("us", tz="Europe/Paris"),
     pa.duration("s"),
     pa.decimal128(19, 4),
     pa.decimal256(76, 38),
     pa.binary(10),
     pa.list_(pa.int32(), 2),
     pa.map_(pa.string(), pa.int32()),
     pa.union(
         [pa.field("a", pa.binary(10)), pa.field("b", pa.string())],
         mode=pa.lib.UnionMode_DENSE,
     ),
     pa.union(
         [pa.field("a", pa.binary(10)), pa.field("b", pa.string())],
         mode=pa.lib.UnionMode_DENSE,
         type_codes=[4, 8],
     ),
     pa.union(
         [pa.field("a", pa.binary(10)), pa.field("b", pa.string())],
         mode=pa.lib.UnionMode_SPARSE,
     ),
     pa.union(
         [
             pa.field("a", pa.binary(10), nullable=False),
             pa.field("b", pa.string()),
         ],
         mode=pa.lib.UnionMode_SPARSE,
     ),
 ]

For more context see https://github.com/apache/arrow-rs/pull/439/files#r653683238

@kszucs kszucs added enhancement Any new improvement worthy of a entry in the changelog python labels Jun 21, 2021
@alippai
Copy link
Contributor

alippai commented Jun 21, 2021

Timestamp and decimal128 is added here: #453

@kszucs
Copy link
Member Author

kszucs commented Jun 21, 2021

Thanks @alippai for the heads-up! We can incrementally update this ticket as new types get implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants