Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Decimal256 in FFI #3453

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Support Decimal256 in FFI #3453

merged 1 commit into from
Jan 5, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 4, 2023

Which issue does this PR close?

Closes #477.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 4, 2023
@tustvold
Copy link
Contributor

tustvold commented Jan 4, 2023

CI appears to be failing 😢

FAILED tests/test_sql.py::test_type_roundtrip[decimal256(76, 38)] - pyarrow.lib.ArrowException: C Data interface error: Only 128/256 bit wide decimal is supported in the Rust implementation

@viirya
Copy link
Member Author

viirya commented Jan 4, 2023

Huh..Let me look at the failure.

EDIT: found the cause.

@viirya viirya merged commit 5dafa4d into apache:master Jan 5, 2023
@ursabot
Copy link

ursabot commented Jan 5, 2023

Benchmark runs are scheduled for baseline = 28a04db and contender = 5dafa4d. 5dafa4d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve type support for the python FFI bridge
3 participants