Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated safety example from readme #1050

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 17, 2021

Which issue does this PR close?

N/A

Rationale for this change

With the release of arrow 6.4.0 the example unsafe code in the readme is no longer possible, so remove it

What changes are included in this PR?

Remove outdated safety example from readme

Are there any user-facing changes?

Doc updates only

@alamb alamb added documentation Improvements or additions to documentation arrow Changes to the arrow crate labels Dec 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1050 (2176f3e) into master (2d28534) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2176f3e differs from pull request most recent head eceb0d6. Consider uploading reports for the commit eceb0d6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
- Coverage   82.31%   82.31%   -0.01%     
==========================================
  Files         168      168              
  Lines       49056    49056              
==========================================
- Hits        40382    40378       -4     
- Misses       8674     8678       +4     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.46%) ⬇️
arrow/src/array/transform/mod.rs 84.96% <0.00%> (-0.28%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
arrow/src/datatypes/field.rs 53.68% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d28534...eceb0d6. Read the comment docs.

@alamb alamb merged commit caa52ef into apache:master Dec 17, 2021
@alamb alamb deleted the alamb/safety_example branch December 17, 2021 17:54
alamb added a commit that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants