Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new DecimalArray creation API in parquet crate #1247

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 29, 2022

Builds on #1223 so draft until that is done

Rationale:

#1223 introduces a more performant and idiomatic API for creating DecimalArrays than DecimalBuilder so update the code to use that.

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jan 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #1247 (f204604) into master (aac1844) will increase coverage by 0.02%.
The diff coverage is 91.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage   82.96%   82.98%   +0.02%     
==========================================
  Files         178      178              
  Lines       51547    51659     +112     
==========================================
+ Hits        42765    42870     +105     
- Misses       8782     8789       +7     
Impacted Files Coverage Δ
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/datatypes/datatype.rs 66.40% <66.66%> (-0.41%) ⬇️
parquet/src/arrow/array_reader.rs 78.31% <85.71%> (+0.10%) ⬆️
arrow/src/array/array_binary.rs 93.39% <93.16%> (-0.10%) ⬇️
arrow/src/array/builder.rs 86.73% <100.00%> (-0.04%) ⬇️
arrow/src/array/data.rs 83.13% <100.00%> (+0.10%) ⬆️
arrow/src/compute/kernels/cast.rs 95.21% <100.00%> (+<0.01%) ⬆️
arrow/src/csv/reader.rs 88.12% <100.00%> (ø)
parquet/src/arrow/arrow_writer.rs 97.96% <100.00%> (-0.02%) ⬇️
parquet/src/arrow/converter.rs 63.96% <100.00%> (-0.39%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac1844...f204604. Read the comment docs.

@alamb alamb force-pushed the alamb/clean_up_decimal_creation branch from f204604 to 7d8bf2d Compare February 8, 2022 20:11
@alamb alamb marked this pull request as ready for review February 8, 2022 20:12
@alamb
Copy link
Contributor Author

alamb commented Feb 8, 2022

FYI @liukun4515

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 5d1cea7 into apache:master Feb 13, 2022
@alamb alamb deleted the alamb/clean_up_decimal_creation branch February 13, 2022 13:26
@alamb alamb changed the title Use new DecimalArray creation API in parquet crate Use new DecimalArray creation API in parquet crate Feb 16, 2022
@alamb alamb added the development-process Related to development process of arrow-rs label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants