Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bitmap::new #1343

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi [email protected]

Which issue does this PR close?

Closes #1337.

Rationale for this change

bit_util has provided some functions to calculate the ceiling and multiple, so we can use them in Bitmap::new to achieve a faster and cleaner code.

What changes are included in this PR?

Are there any user-facing changes?

None.

Signed-off-by: remzi <[email protected]>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1343 (d8dd8dc) into master (ecba7dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         181      181           
  Lines       52937    52934    -3     
=======================================
- Hits        43960    43958    -2     
+ Misses       8977     8976    -1     
Impacted Files Coverage Δ
arrow/src/bitmap.rs 87.50% <100.00%> (-0.64%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 84.65% <0.00%> (+0.13%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba7dc...d8dd8dc. Read the comment docs.

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao merged commit 89ee9ac into apache:master Feb 21, 2022
@sunchao
Copy link
Member

sunchao commented Feb 21, 2022

Merged, thanks @HaoYang670 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the code of Bitmap::new
3 participants