Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add LargeUtf8 support in json writer #1358

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

tiphaineruy
Copy link
Contributor

Which issue does this PR close?

Closes #1357

Rationale for this change

Allows writing LargeUtf8 to Json

What changes are included in this PR?

Change ton json writer to allow LargeUtf8 to json conversion

Might impact roundTrip

Are there any user-facing changes?

None

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1358 (26a4292) into master (a69f0d1) will decrease coverage by 0.00%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
- Coverage   83.04%   83.03%   -0.01%     
==========================================
  Files         181      181              
  Lines       52925    52943      +18     
==========================================
+ Hits        43950    43960      +10     
- Misses       8975     8983       +8     
Impacted Files Coverage Δ
arrow/src/json/writer.rs 91.77% <72.22%> (-0.70%) ⬇️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 84.39% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69f0d1...26a4292. Read the comment docs.

@houqp houqp merged commit abe2cf2 into apache:master Feb 23, 2022
@tiphaineruy tiphaineruy deleted the largeutf8-jsonwriter branch February 24, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for LargeUtf8 in json writer
4 participants