Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to check FixedSizeBinaryArray input all none #1405

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Mar 6, 2022

Which issue does this PR close?

Closes #1390.

Rationale for this change

I found that problem in #1390 is solved.

What changes are included in this PR?

Add a unit test to check the situation that input of FixedSizeBinaryArray all is none.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 6, 2022
@jackwener
Copy link
Member Author

@alamb PTAL

@alamb
Copy link
Contributor

alamb commented Mar 6, 2022

👍 thank you @jackwener !

@codecov-commenter
Copy link

Codecov Report

Merging #1405 (886184b) into master (ab41c25) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   83.10%   83.13%   +0.02%     
==========================================
  Files         181      181              
  Lines       53244    53335      +91     
==========================================
+ Hits        44247    44338      +91     
  Misses       8997     8997              
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 93.28% <100.00%> (+0.05%) ⬆️
arrow/src/array/transform/mod.rs 86.31% <0.00%> (-0.12%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet/src/file/serialized_reader.rs 95.65% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41c25...886184b. Read the comment docs.

@jackwener jackwener closed this Mar 6, 2022
@alamb alamb reopened this Mar 6, 2022
@alamb alamb closed this Mar 6, 2022
@jackwener
Copy link
Member Author

@alamb After thinking about it for a while, I think that although this ut does not solve the problem, it is also a supplement to the case, maybe we can still merge

@alamb alamb reopened this Mar 7, 2022
@alamb
Copy link
Contributor

alamb commented Mar 7, 2022

I agree it seems reasonable to add a new unit test -- thank you @jackwener

@alamb alamb merged commit e40bc91 into apache:master Mar 7, 2022
@jamescorbett
Copy link

As Jack mentioned on the original issue this does not fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixedSizeBinaryArray::try_from_sparse_iter failed when given all Nones
4 participants