-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add length
kernel support for List Array
#1488
Add length
kernel support for List Array
#1488
Conversation
code format Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 82.71% 82.73% +0.02%
==========================================
Files 187 188 +1
Lines 54255 54319 +64
==========================================
+ Hits 44877 44941 +64
Misses 9378 9378
Continue to review full report at Codecov.
|
arrow/src/compute/kernels/length.rs
Outdated
/// * length of null is null. | ||
/// * length is in number of bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// * length of null is null. | |
/// * length is in number of bytes | |
/// * length of null is null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Signed-off-by: remzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HaoYang670 and @viirya
Which issue does this PR close?
Closes #1470 .
What changes are included in this PR?
length
kernel support for list arrayAre there any user-facing changes?
Doc of the public function
length
is updated.