Implement size_hint and ExactSizedIterator for DecimalArray
#1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
size_hint and ExactSizedIterator for DecimalArray
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 188 188
Lines 54354 54370 +16
=======================================
+ Hits 44970 44987 +17
+ Misses 9384 9383 -1
Continue to review full report at Codecov.
|
viirya
reviewed
Mar 29, 2022
viirya
reviewed
Mar 29, 2022
arrow/src/array/array_binary.rs
Outdated
| } | ||
|
|
||
| /// iterator has have known size. | ||
| impl<'a> std::iter::ExactSizeIterator for DecimalIter<'a> {} |
There was a problem hiding this comment.
Should we have it in iterator.rs? I see other ExactSizeIterators implementations located there.
There was a problem hiding this comment.
🤔 that is a good idea. I can certainly move it there.
viirya
reviewed
Mar 29, 2022
|
Thanks for the review @viirya ! |
Co-authored-by: Liang-Chi Hsieh <[email protected]>
viirya
approved these changes
Mar 29, 2022
|
lgtm. thanks @alamb ! |
yjshen
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1505
Rationale for this change
I was doing some small cleanups in DataFusion apache/datafusion#2107 and noticed that the DecimalArray iterators do not report their exact size. The exact size is used in several places for optimizations in Arrow
What changes are included in this PR?
Are there any user-facing changes?
Can use DecimalArray::iter() in more situations