-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map nullable flag in ParquetTypeConverter
#1592
Conversation
@@ -1018,7 +1018,7 @@ impl ParquetTypeConverter<'_> { | |||
Box::new(Field::new( | |||
key_item.name(), | |||
DataType::Struct(vec![key, value]), | |||
false, | |||
self.schema.is_optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to previous inconsistency I described in the ticket, I changed this to follow visit_map
.
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 82.93% 82.95% +0.01%
==========================================
Files 193 193
Lines 55350 55376 +26
==========================================
+ Hits 45907 45939 +32
+ Misses 9443 9437 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed this aligns with the specification - https://github.com/apache/parquet-format/blob/master/LogicalTypes.md
Thank you @tustvold for confirming it. |
Which issue does this PR close?
Closes #1587.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?