Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for arrow-rs 13.0.0 release #1624

Merged
merged 8 commits into from
Apr 29, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 27, 2022

Which issue does this PR close?

re #1623

Rationale for this change

see subject

What changes are included in this PR?

  1. Update version
  2. Changelog. See rendered version here: https://github.com/alamb/arrow-rs/blob/alamb/prepare_for_13.0.0/CHANGELOG.md

@alamb alamb added the development-process Related to development process of arrow-rs label Apr 27, 2022
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Apr 27, 2022
CHANGELOG.md Outdated
- ListArray::from\(ArrayData\) dereferences invalid pointer when offsets are empty [\#1601](https://github.com/apache/arrow-rs/issues/1601) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)]
- Incorrect nullable flag when reading maps \( test\_read\_maps fails when `force_validate` is active\) [\#1587](https://github.com/apache/arrow-rs/issues/1587) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)]
- Output of `ipc::reader::tests::projection_should_work` fails validation [\#1548](https://github.com/apache/arrow-rs/issues/1548) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)]
- Parquet: schema validation should allow scale == precision for decimal type [\#1607](https://github.com/apache/arrow-rs/pull/1607) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] ([sunchao](https://github.com/sunchao))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same with the first one Parquet schema should allow scale == precision for decimal type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- good call -- the script generates a line for every issue and PR marked bug -- I will remove the duplication. Thank you for the review @viirya

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one question.

@codecov-commenter
Copy link

Codecov Report

Merging #1624 (312075a) into master (ded4ce8) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   82.94%   83.03%   +0.08%     
==========================================
  Files         193      193              
  Lines       55635    55472     -163     
==========================================
- Hits        46148    46060      -88     
+ Misses       9487     9412      -75     
Impacted Files Coverage Δ
arrow/src/array/equal/structure.rs 95.00% <0.00%> (-5.00%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/data.rs 83.05% <0.00%> (-0.20%) ⬇️
arrow/src/ipc/reader.rs 89.37% <0.00%> (-0.07%) ⬇️
arrow/src/array/array_union.rs 90.71% <0.00%> (ø)
arrow/src/array/equal/union.rs 100.00% <0.00%> (ø)
arrow/src/array/equal/boolean.rs 97.14% <0.00%> (ø)
arrow/src/array/equal/decimal.rs 100.00% <0.00%> (ø)
arrow/src/array/equal/primitive.rs 100.00% <0.00%> (ø)
arrow/src/array/equal/dictionary.rs 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded4ce8...312075a. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Apr 29, 2022

Waiting for #1621 and #1629

@alamb
Copy link
Contributor Author

alamb commented Apr 29, 2022

Merging this one in to create a release candidate

@alamb alamb merged commit 7d00e3c into apache:master Apr 29, 2022
@alamb alamb deleted the alamb/prepare_for_13.0.0 branch April 29, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants