-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrary size combine option bitmap #1781
Arbitrary size combine option bitmap #1781
Conversation
Still need to add tests for buffers with offsets. |
Codecov Report
@@ Coverage Diff @@
## master #1781 +/- ##
=======================================
Coverage 83.39% 83.40%
=======================================
Files 198 198
Lines 56142 56222 +80
=======================================
+ Hits 46822 46890 +68
- Misses 9320 9332 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits, very nice 👍. I think this has a bug, however, but the fix should be very simple and easy to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Leave some comments.
thanks! @HaoYang670 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, will merge once CI finishes. Thanks again 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @Ismail-Maj !!
Which issue does this PR close?
Closes #1780.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?