Remove PrimitiveBuilder::finish_dict
(#1978)
#1980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1978
Part of #1979
Rationale for this change
The finish_dict method has always struck me as a little bit strange, and it is definitely not safe. This PR just removes it
What changes are included in this PR?
Starts the process of #1979 and uses this to remove the need for
PrimitiveBuilder::finish_dict
Are there any user-facing changes?
Yes, this removes an API