Implement Into<ArrayData>
for T: Array
#1992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1979
Rationale for this change
The method
into_data
is a cheaper alternative to the more pervasive.data().clone()
calls to get underlying array data. It's cheaper since it doesn't clone anything but returns already allocated data (except forArrayRef
).What changes are included in this PR?
It implements
Into
indirectly to convert specific array type to general one.Are there any user-facing changes?
It adds
fn into_data(self) -> ArrayData
method toArray
trait.