Add `Decimal256Builder` and `Decimal256Array`; Decimal arrays now implement `BasicDecimalArray` trait #2000

viirya · 2022-07-04T08:30:20Z

Which issue does this PR close?

Closes #1999.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

viirya · 2022-07-04T08:38:34Z

Marked as draft now and I will add some tests and dedup some codes.

liukun4515 · 2022-07-05T08:35:59Z

If it is ready, please @ me. @viirya

codecov-commenter · 2022-07-05T19:38:30Z

Codecov Report

Merging #2000 (7c3e00f) into master (2309157) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
- Coverage   83.58%   83.58%   -0.01%     
==========================================
  Files         222      222              
  Lines       57529    57603      +74     
==========================================
+ Hits        48088    48145      +57     
- Misses       9441     9458      +17

Impacted Files	Coverage Δ
arrow/src/array/equal_json.rs	`87.89% <0.00%> (-1.81%)`	⬇️
arrow/src/array/iterator.rs	`96.11% <ø> (ø)`
arrow/src/array/mod.rs	`100.00% <ø> (ø)`
arrow/src/array/ord.rs	`69.17% <ø> (ø)`
arrow/src/compute/kernels/cast.rs	`95.79% <ø> (ø)`
arrow/src/compute/kernels/sort.rs	`95.67% <ø> (ø)`
arrow/src/compute/kernels/take.rs	`95.27% <ø> (ø)`
arrow/src/csv/reader.rs	`89.89% <ø> (ø)`
arrow/src/util/decimal.rs	`91.50% <ø> (ø)`
arrow/src/util/display.rs	`73.17% <ø> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2309157...7c3e00f. Read the comment docs.

viirya · 2022-07-06T05:15:20Z

cc @alamb @tustvold @liukun4515

alamb

I think the code looks good to me 👍 Nice work @viirya and thank you!

I have some comments regarding checking for mismatch in precision / scale between the builder and values, but otherwise I think this PR looks good to me.

alamb · 2022-07-06T19:23:31Z

arrow/src/array/builder/decimal_builder.rs

+    pub fn append_value(&mut self, value: &Decimal256) -> Result<()> {
+        let value_as_bytes = value.raw_value();
+
+        if self.builder.value_length() != value_as_bytes.len() as i32 {


I wonder if we also need to check the precision and scale of value (and either error if they don't match the builder or do conversion if required) 🤔

Good point. I think we should. It is a cheap check too so I think okay.

alamb · 2022-07-06T19:24:10Z

arrow/src/array/builder/decimal_builder.rs

+        bytes = vec![0; 32];
+        bytes[0..16].clone_from_slice(&0_i128.to_le_bytes());
+        bytes[15] = 128;
+        let value = Decimal256::try_new_from_bytes(40, 6, bytes.as_slice()).unwrap();


I think we should add a test for appending a value that has a precision/scale other than 40. 6, as I mentioned above

tustvold · 2022-07-07T13:29:13Z

Should I be reviewing this or #2006, they seem to implement the same functionality?

viirya · 2022-07-07T14:31:36Z

@tustvold I'd prefer this. #2006 is just for showing the alternative concept. But there is some issues. Please review this, thanks.

HaoYang670 · 2022-07-08T01:23:12Z

arrow/src/array/builder/decimal_builder.rs

+/// See [`Decimal256Array`] for example.
+#[derive(Debug)]
+pub struct Decimal256Builder {
+    builder: FixedSizeListBuilder<UInt8Builder>,


It may be more straightforward to build decimal array based on FixedSizeBinaryBuilder. I will file a followup issue.

Create #2026 to track this.

I also confused about that we use the the FixedSizeListBuilder to store decimal data in the decimal builder.

alamb · 2022-07-08T15:57:29Z

@tustvold is this one good to go (for arrow 18?)

alamb · 2022-07-08T17:25:28Z

I see now that @liukun4515 asked to be pinged on this PR for review, which @viirya did but then I merged it prior to @liukun4515 having a chance to review.

@liukun4515 I will make the 18.0.0 release candidate but if you find issues with the API or some other reason we should not release 18.0.0 with this change in it, please let me know and we can make changes prior to release.

liukun4515 · 2022-07-11T10:36:31Z

I see now that @liukun4515 asked to be pinged on this PR for review, which @viirya did but then I merged it prior to @liukun4515 having a chance to review.

@liukun4515 I will make the 18.0.0 release candidate but if you find issues with the API or some other reason we should not release 18.0.0 with this change in it, please let me know and we can make changes prior to release.

Sorry for the later reply, I am busy with other task.
This pr looks great for me.
And from #2000 (comment), it's better to refactor the builder and generate the array data from fixed list builder to fixed binary builder.

viirya marked this pull request as draft July 4, 2022 08:30

github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jul 4, 2022

viirya force-pushed the decimal256array branch from 3fd533e to 36d23e6 Compare July 5, 2022 06:16

viirya mentioned this pull request Jul 5, 2022

Add Decimal256Builder and Decimal256Array (generic approach) #2006

Closed

viirya added 3 commits July 5, 2022 12:15

Add Decimal256Builder and Decimal256Array

fc2e23f

Add decimal builder test

9bbb42f

Rebased with master

1dd13ea

viirya force-pushed the decimal256array branch from 20186bb to 1dd13ea Compare July 5, 2022 19:18

viirya added 2 commits July 5, 2022 12:58

Trigger Build

8a41ec8

Disable value validation for precision > 38

ea3653e

viirya marked this pull request as ready for review July 5, 2022 21:26

viirya added 2 commits July 5, 2022 14:34

Deduplicate by using macro

7c3e00f

Trigger Build

ec0d4fa

alamb approved these changes Jul 6, 2022

View reviewed changes

Add precision and scale check

6eb38d2

HaoYang670 reviewed Jul 8, 2022

View reviewed changes

alamb merged commit ca1bfb8 into apache:master Jul 8, 2022

alamb changed the title ~~Add Decimal256Builder and Decimal256Array~~ Add Decimal256Builder and Decimal256Array Jul 8, 2022

alamb added the api-change Changes to the arrow API label Jul 8, 2022

alamb changed the title ~~Add Decimal256Builder and Decimal256Array~~ Add Decimal256Builder and Decimal256Array; Decimal arrays now implement BasicDecimalArray trait Jul 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Decimal256Builder` and `Decimal256Array`; Decimal arrays now implement `BasicDecimalArray` trait #2000

Add `Decimal256Builder` and `Decimal256Array`; Decimal arrays now implement `BasicDecimalArray` trait #2000

viirya commented Jul 4, 2022

viirya commented Jul 4, 2022

liukun4515 commented Jul 5, 2022 •

edited

Loading

codecov-commenter commented Jul 5, 2022 •

edited

Loading

viirya commented Jul 6, 2022

alamb left a comment

alamb Jul 6, 2022 •

edited

Loading

viirya Jul 6, 2022

alamb Jul 6, 2022

tustvold commented Jul 7, 2022

viirya commented Jul 7, 2022

HaoYang670 Jul 8, 2022

HaoYang670 Jul 8, 2022

liukun4515 Jul 11, 2022

alamb commented Jul 8, 2022

alamb commented Jul 8, 2022

liukun4515 commented Jul 11, 2022

Add Decimal256Builder and Decimal256Array; Decimal arrays now implement BasicDecimalArray trait #2000

Add Decimal256Builder and Decimal256Array; Decimal arrays now implement BasicDecimalArray trait #2000

Conversation

viirya commented Jul 4, 2022

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

viirya commented Jul 4, 2022

liukun4515 commented Jul 5, 2022 • edited Loading

codecov-commenter commented Jul 5, 2022 • edited Loading

Codecov Report

viirya commented Jul 6, 2022

alamb left a comment

Choose a reason for hiding this comment

alamb Jul 6, 2022 • edited Loading

Choose a reason for hiding this comment

viirya Jul 6, 2022

Choose a reason for hiding this comment

alamb Jul 6, 2022

Choose a reason for hiding this comment

tustvold commented Jul 7, 2022

viirya commented Jul 7, 2022

HaoYang670 Jul 8, 2022

Choose a reason for hiding this comment

HaoYang670 Jul 8, 2022

Choose a reason for hiding this comment

liukun4515 Jul 11, 2022

Choose a reason for hiding this comment

alamb commented Jul 8, 2022

alamb commented Jul 8, 2022

liukun4515 commented Jul 11, 2022

Add `Decimal256Builder` and `Decimal256Array`; Decimal arrays now implement `BasicDecimalArray` trait #2000

Add `Decimal256Builder` and `Decimal256Array`; Decimal arrays now implement `BasicDecimalArray` trait #2000

liukun4515 commented Jul 5, 2022 •

edited

Loading

codecov-commenter commented Jul 5, 2022 •

edited

Loading

alamb Jul 6, 2022 •

edited

Loading