Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify null mask preservation in parquet reader #2116

Merged
merged 6 commits into from
Jul 22, 2022
Merged

Simplify null mask preservation in parquet reader #2116

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1357d1
Simplify null mask preservation
tustvold Jul 20, 2022
fd039ec
Fix benchmarks
tustvold Jul 20, 2022
4b40729
Remove PackedDecoder Option
tustvold Jul 20, 2022
467c876
Use match expression
tustvold Jul 21, 2022
a7b7c36
Remove inline from GenericColumnReader::read_batch
tustvold Jul 21, 2022
98c9a9a
Merge remote-tracking branch 'upstream/master' into simplify-null-mas…
tustvold Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion parquet/src/column/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ where
///
/// `values` will be contiguously populated with the non-null values. Note that if the column
/// is not required, this may be less than either `batch_size` or the number of levels read
#[inline]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would appear that this can result in sub-optimal inlining behaviour, in particular when compiling the parquet crate there is a noticeable performance degredation. Unfortunately the inlined code is so mangled that I've been unable to determine exactly what is going on, but I may revisit this at a later date

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in "when you leave inline the benchmarks get slower"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you leave inline certain benchmarks get slower when compiled from the parquet crate, although there is no difference when compiled from the workspace level... It is incredibly strange...

pub fn read_batch(
&mut self,
batch_size: usize,
Expand Down