Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid decoding unneeded values in ByteArrayDecoderDictionary #2154

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

thinkharderdev
Copy link
Contributor

Which issue does this PR close?

Closes #2088

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2154 (b340d55) into master (1621c71) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   82.85%   82.83%   -0.02%     
==========================================
  Files         237      237              
  Lines       61381    61381              
==========================================
- Hits        50856    50846      -10     
- Misses      10525    10535      +10     
Impacted Files Coverage Δ
parquet/src/arrow/array_reader/byte_array.rs 85.79% <44.44%> (ø)
...rquet/src/arrow/record_reader/definition_levels.rs 84.38% <0.00%> (-3.38%) ⬇️
arrow/src/datatypes/datatype.rs 62.69% <0.00%> (-0.32%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tustvold tustvold merged commit bd65d59 into apache:master Jul 25, 2022
@ursabot
Copy link

ursabot commented Jul 25, 2022

Benchmark runs are scheduled for baseline = 73153fe and contender = bd65d59. bd65d59 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make skip value in ByteArrayDecoderDictionary avoid decoding
4 participants