Fix Copy from percent-encoded path (#2353) #2354
Conversation
| container: &self.container_name, | ||
| })?; | ||
|
|
||
| url.path_segments_mut().unwrap().extend(from.parts()); |
There was a problem hiding this comment.
Don't need to encode the path here?
There was a problem hiding this comment.
That's what extend does, and what this PR is changing. Sorry I should have called this out 😄
There was a problem hiding this comment.
Oh, I see. Thanks for pointing to the doc. I thought it just simply extend the content. 😄
|
Benchmark runs are scheduled for baseline = 5676c6e and contender = a2de363. a2de363 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2353
Rationale for this change
I added this test in #2352 and realised it was failing for the existing AWS implementation, and Azure. This fixes the behaviour
What changes are included in this PR?
Are there any user-facing changes?
No