Derive Copy,Clone for BasicDecimal #2495
Conversation
arrow/benches/array_from_vec.rs
Outdated
| @@ -80,26 +80,18 @@ fn decimal128_array_from_vec(array: &[Option<i128>]) { | |||
| criterion::black_box( | |||
| array | |||
| .iter() | |||
| .copied() | |||
There was a problem hiding this comment.
This is failing to compile on master see #2494
| // bench decimal256 array | ||
| c.bench_function("decimal256_array_from_vec 32768", |b| { | ||
| b.iter(|| decimal256_array_from_vec) | ||
| b.iter(|| decimal256_array_from_vec(array.as_slice())) |
There was a problem hiding this comment.
This is now more realistic as it is no longer benchmarking the decimal assembly code
|
Benchmark runs are scheduled for baseline = 4459a0e and contender = 97b4f65. 97b4f65 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Following #2442 changing the DecimalArray from iterator to take Into, the lack of
Copyor evenCloneonBasicDecimalmakes for a very clunky experience.