Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iterator for FixedSizeBinaryArray #2531

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Add iterator for FixedSizeBinaryArray #2531

merged 1 commit into from
Aug 19, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 19, 2022
tustvold
tustvold commented Aug 19, 2022
View reviewed changes
arrow/src/array/array_fixed_size_binary.rs
@@ -362,6 +368,27 @@ impl Array for FixedSizeBinaryArray {
}
}

impl<'a> ArrayAccessor for &'a FixedSizeBinaryArray {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very pleased with this trait

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

tustvold
tustvold commented Aug 19, 2022
View reviewed changes
arrow/src/array/array_binary.rs
/// constructs a new iterator
pub fn iter(&'a self) -> GenericBinaryIter<'a, T> {
GenericBinaryIter::<'a, T>::new(self)
pub fn iter(&self) -> GenericBinaryIter<'_, OffsetSize> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by cleanup

@tustvold tustvold mentioned this pull request Aug 19, 2022
Merged
@tustvold tustvold merged commit 0f45932 into apache:master Aug 19, 2022
@ursabot
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = c20bb8a and contender = 0f45932. 0f45932 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

amrltqt pushed a commit to amrltqt/arrow-rs that referenced this pull request Aug 20, 2022
@tustvold @amrltqt
Add iterator for FixedSizeBinaryArray (apache#2531)
a879485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tustvold @ursabot @viirya