-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip RowSelectors with zero rows #2678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we possibly get a test of this
Is it okay if I modify the test |
I think it would be nice to have a fully reproducible test, the fuzz tests are really there to find gaps in test coverage not to serve as it. |
I created a test borrowing heavily from the fuzz test. Let me know if it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Benchmark runs are scheduled for baseline = df4906d and contender = 0b59f05. 0b59f05 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2669
Are there any user-facing changes?
no user-facing or breaking changes.