Specialize filter kernel for binary arrays (#2969) #2971
Conversation
tustvold
changed the title
alamb
changed the title
| @@ -626,17 +626,17 @@ where | |||
| /// | |||
| /// Note: NULLs with a non-zero slot length in `array` will have the corresponding | |||
| /// data copied across. This allows handling the null mask separately from the data | |||
| fn filter_string<OffsetSize>( | |||
| array: &GenericStringArray<OffsetSize>, | |||
| fn filter_bytes<T>( | |||
There was a problem hiding this comment.
The comment a few lines above is now out of date:
///
filterimplementation for string arrays
Should be:
///
filterimplementation for byte arrays
| @@ -626,17 +626,17 @@ where | |||
| /// | |||
There was a problem hiding this comment.
Not shown in the diff, but the comment is out-of-dated:
/// `filter` implementation for string arrays
|
Benchmark runs are scheduled for baseline = c7f97c2 and contender = 62e878e. 62e878e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #2969
Rationale for this change
Should make filtering byte arrays significantly faster, we actually lacked a specialized implementation for them
What changes are included in this PR?
Are there any user-facing changes?