Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: remove redundant prefix #2983

Merged
merged 2 commits into from
Oct 31, 2022
Merged

minor: remove redundant prefix #2983

merged 2 commits into from
Oct 31, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Oct 30, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

When I read source code about Arrow-flight, find some redundant prefix

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Oct 30, 2022
@jackwener
Copy link
Member Author

Don't understand why CI reports an error, is it because these codes are not allowed to change?

@tustvold
Copy link
Contributor

is it because these codes are not allowed to change

arrow.flight.protocol.rs and arrow.flight.protocol.sql.rs are auto-generated and shouldn't be altered manually

@tustvold tustvold merged commit 3db7f42 into apache:master Oct 31, 2022
@ursabot
Copy link

ursabot commented Oct 31, 2022

Benchmark runs are scheduled for baseline = 3a90654 and contender = 3db7f42. 3db7f42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants