-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parquet to depend on arrow subcrates #3028
Changes from all commits
620a04c
9286607
d973e13
a7d0038
d341f57
7dcd70a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,15 @@ edition = "2021" | |
rust-version = "1.62" | ||
|
||
[dependencies] | ||
arrow-array = { version = "26.0.0", path = "../arrow-array", default-features = false, optional = true } | ||
arrow-buffer = { version = "26.0.0", path = "../arrow-buffer", default-features = false, optional = true } | ||
arrow-cast = { version = "26.0.0", path = "../arrow-cast", default-features = false, optional = true } | ||
arrow-csv = { version = "26.0.0", path = "../arrow-csv", default-features = false, optional = true } | ||
arrow-data = { version = "26.0.0", path = "../arrow-data", default-features = false, optional = true } | ||
arrow-schema = { version = "26.0.0", path = "../arrow-schema", default-features = false, optional = true } | ||
arrow-select = { version = "26.0.0", path = "../arrow-select", default-features = false, optional = true } | ||
arrow-ipc = { version = "26.0.0", path = "../arrow-ipc", default-features = false, optional = true } | ||
|
||
ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] } | ||
bytes = { version = "1.1", default-features = false, features = ["std"] } | ||
thrift = { version = "0.16", default-features = false } | ||
|
@@ -41,7 +50,6 @@ zstd = { version = "0.11.1", optional = true, default-features = false } | |
chrono = { version = "0.4", default-features = false, features = ["alloc"] } | ||
num = { version = "0.4", default-features = false } | ||
num-bigint = { version = "0.4", default-features = false } | ||
arrow = { path = "../arrow", version = "26.0.0", optional = true, default-features = false, features = ["ipc"] } | ||
base64 = { version = "0.13", default-features = false, features = ["std"], optional = true } | ||
clap = { version = "4", default-features = false, features = ["std", "derive", "env", "help", "error-context", "usage"], optional = true } | ||
serde_json = { version = "1.0", default-features = false, features = ["std"], optional = true } | ||
|
@@ -70,9 +78,9 @@ all-features = true | |
[features] | ||
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"] | ||
# Enable arrow reader/writer APIs | ||
arrow = ["dep:arrow", "base64"] | ||
arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"] | ||
Comment on lines
79
to
+81
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems two lines can combined? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nvm, I thought if this |
||
# Enable CLI tools | ||
cli = ["json", "base64", "clap", "arrow/csv"] | ||
cli = ["json", "base64", "clap", "arrow-csv"] | ||
# Enable JSON APIs | ||
json = ["serde_json", "base64"] | ||
# Enable internal testing APIs | ||
|
@@ -100,7 +108,7 @@ required-features = ["cli"] | |
|
||
[[bin]] | ||
name = "parquet-fromcsv" | ||
required-features = ["cli"] | ||
required-features = ["arrow", "cli"] | ||
|
||
[[bench]] | ||
name = "arrow_writer" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is somewhat unfortunate the number of these, perhaps we should provide re-exports to reduce this. On the flip side, parquet is a very complex crate and so perhaps it is just a bit special in needing all the things 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for some basic crates like arrow-buffer, arrow-data, arrow-schema, perhaps we can provide re-export (arrow-core?) for them.
Like you said, if this is just a special case, then it is fine.