-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out arrow-json (#3044) #3049
Conversation
lexical-core = { version = "^0.8", default-features = false, features = ["write-integers", "write-floats", "parse-integers", "parse-floats"] } | ||
multiversion = { version = "0.6.1", default-features = false } | ||
bitflags = { version = "1.2.1", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just drive-by-fixes. They are no longer needed by the top-level crate
arrow-json/src/reader.rs
Outdated
//! use std::fs::File; | ||
//! use std::io::BufReader; | ||
//! use std::sync::Arc; | ||
//! ```no_run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why change to no_run
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops need to revert
File::open("test/data/uk_cities_with_headers.csv").unwrap(), | ||
), | ||
None, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We drop this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it just isn't part of the arrow-json test data
Benchmark runs are scheduled for baseline = fe3318b and contender = 8d75101. 8d75101 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3044
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?