Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparison op: decimal128 array with scalar #3141

Merged
merged 1 commit into from
Nov 20, 2022
Merged

comparison op: decimal128 array with scalar #3141

merged 1 commit into from
Nov 20, 2022

Conversation

liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Nov 19, 2022 •
edited
Loading

Which issue does this PR close?

Closes #3140

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 19, 2022
@liukun4515 liukun4515 mentioned this pull request Nov 19, 2022
Closed
4 tasks
@liukun4515 liukun4515 requested review from alamb and viirya November 19, 2022 08:55
viirya
viirya reviewed Nov 19, 2022
View reviewed changes
arrow/src/compute/kernels/comparison.rs Outdated
Comment on lines 6981 to 6985
let e = BooleanArray::from(
vec![Some(false), Some(false), Some(false), None, Some(true), Some(true)],
);
let r = gt_eq_scalar(&a, b).unwrap();
assert_eq!(e, r);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let e = BooleanArray::from(
vec![Some(false), Some(false), Some(false), None, Some(true), Some(true)],
);
let r = gt_eq_scalar(&a, b).unwrap();
assert_eq!(e, r);
let e = BooleanArray::from(
vec![Some(false), Some(false), Some(true), None, Some(true), Some(true)],
);
let r = gt_eq_scalar(&a, b).unwrap();
assert_eq!(e, r);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been checked by the test in my local, and change it.
Thanks

@liukun4515 liukun4515 force-pushed the comparison_decimla_scalar branch from 3a81a93 to 256df93 Compare November 19, 2022 09:06
@viirya viirya merged commit 475e079 into apache:master Nov 20, 2022
@ursabot
Copy link

ursabot commented Nov 20, 2022

Benchmark runs are scheduled for baseline = 5bce104 and contender = 475e079. 475e079 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515 liukun4515 deleted the comparison_decimla_scalar branch November 20, 2022 13:12
@alamb alamb mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@alamb alamb Awaiting requested review from alamb

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support comparison for decimal128 array with scalar in kernel
3 participants
@liukun4515 @ursabot @viirya