Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To pyarrow with schema #3188

Merged
merged 4 commits into from
Nov 26, 2022
Merged

Conversation

doki23
Copy link
Contributor

@doki23 doki23 commented Nov 25, 2022

closes #3136

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 25, 2022
@doki23 doki23 marked this pull request as ready for review November 25, 2022 05:14
@tustvold
Copy link
Contributor

Is this test actually run in CI? I can't see it in the output?

@doki23
Copy link
Contributor Author

doki23 commented Nov 26, 2022

Yes, seems something went wrong. I guess it's because it was blocked when I first draft this pr but the test was added after that. Can you help retry it?

@tustvold
Copy link
Contributor

tustvold commented Nov 26, 2022

I don't think the CI is configured to run tests with the pyarrow feature enabled?

Edit: I'm looking into updating this so the CI runs

@tustvold tustvold force-pushed the to_pyarrow_with_schema branch from 583ef85 to 89de3c4 Compare November 26, 2022 12:35
@doki23
Copy link
Contributor Author

doki23 commented Nov 26, 2022

Great! 👍🏻

@tustvold tustvold merged commit befea02 into apache:master Nov 26, 2022
@tustvold
Copy link
Contributor

Thank you 👍

@ursabot
Copy link

ursabot commented Nov 26, 2022

Benchmark runs are scheduled for baseline = fd08c31 and contender = befea02. befea02 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrow to and from pyarrow conversion results in changes in schema
3 participants