Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API to validate the precision for decimal array #3242

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add new API to validate the precision for decimal array #3242

merged 2 commits into from
Nov 30, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #3223

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515
support new api to validate decimal array: if value is overflow with …
eb1418e 
…the specified precision, will be changed to None
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 30, 2022
tustvold
tustvold reviewed Nov 30, 2022
View reviewed changes
arrow-array/src/array/primitive_array.rs
/// Validates the Decimal Array, if the value of slot is overflow for the specified precision, and
/// will be casted to Null
pub fn null_if_overflow_precision(self, precision: u8) -> Self {
self.unary_opt::<_, T>(|v| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the friendly api provided from @tustvold @viirya

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tustvold tustvold merged commit fdc3457 into apache:master Nov 30, 2022
@ursabot
Copy link

ursabot commented Nov 30, 2022

Benchmark runs are scheduled for baseline = 54587e0 and contender = fdc3457. fdc3457 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@viirya viirya Awaiting requested review from viirya

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

precision is not considered when cast value to decimal
4 participants
@liukun4515 @ursabot @viirya @tustvold