-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document all features on docs.rs #3377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -40,6 +40,9 @@ prost-derive = { version = "0.11", default-features = false } | |||
tokio = { version = "1.0", default-features = false, features = ["macros", "rt", "rt-multi-thread"] } | |||
futures = { version = "0.3", default-features = false, features = ["alloc"]} | |||
|
|||
[package.metadata.docs.rs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -48,6 +48,9 @@ num = { version = "0.4", default-features = false, features = ["std"] } | |||
[dev-dependencies] | |||
rand = { version = "0.8", default-features = false, features = ["std", "std_rng"] } | |||
|
|||
[package.metadata.docs.rs] | |||
features = ["dyn_cmp_dict"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can't be simd
because it requires nightly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I'm not 100% sure, I'm basing this off the top-level crate and erring on the side of caution as I don't know how to test this 😅
Benchmark runs are scheduled for baseline = c1c97f1 and contender = 9cdc1c1. 9cdc1c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
In particular we weren't generating documentation for flight-sql
What changes are included in this PR?
Are there any user-facing changes?