Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quick-xml to 0.27 #3395

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Update quick-xml to 0.27 #3395

merged 2 commits into from
Dec 27, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold mentioned this pull request Dec 26, 2022
Closed
@github-actions github-actions bot added the object-store Object Store Interface label Dec 26, 2022
tustvold
tustvold commented Dec 26, 2022
View reviewed changes
object_store/src/aws/client.rs
@@ -189,9 +189,9 @@ struct CompleteMultipart {

#[derive(Debug, Serialize)]
struct MultipartPart {
#[serde(rename = "$unflatten=ETag")]
#[serde(rename = "ETag")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$unflatten is no longer needed, and has been removed

@tustvold tustvold marked this pull request as draft December 26, 2022 17:56
@tustvold tustvold marked this pull request as ready for review December 26, 2022 19:56
@tustvold tustvold merged commit 2444994 into apache:master Dec 27, 2022
@ursabot
Copy link

ursabot commented Dec 27, 2022

Benchmark runs are scheduled for baseline = 733b7e7 and contender = 2444994. 2444994 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tustvold @ursabot @viirya @Dandandan