Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store: update localstack instructions #3403

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

wjones127
Copy link
Member

Which issue does this PR close?

Closes #3379.

Rationale for this change

In the newer version of localstack, we need to change the provider to make sure our tests pass. The new provider is more aligned with the true behavior of S3 than the current default in 1.x of localstack. (See upstream issue).

What changes are included in this PR?

Are there any user-facing changes?

@wjones127 wjones127 requested a review from tustvold December 27, 2022 22:02
@github-actions github-actions bot added the object-store Object Store Interface label Dec 27, 2022
@wjones127 wjones127 merged commit b903384 into apache:master Dec 28, 2022
@wjones127 wjones127 deleted the fix/update-s3-contributing branch December 28, 2022 01:13
@ursabot
Copy link

ursabot commented Dec 28, 2022

Benchmark runs are scheduled for baseline = 1d0abfa and contender = b903384. b903384 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_store(aws): percent encoding test fails with latest localstack
3 participants