Update pyarrow method call to avoid warning #3544
Conversation
There was a problem hiding this comment.
An error about type annotation. Otherwise looks like good fix.
error[E0282]: type annotations needed
--> arrow/src/pyarrow.rs:199:68
|
199 | let record = class.call_method1("from_arrays", (py_arrays, None, py_schema))?;
| ^^^^ cannot infer type of the type parameter `T` declared on the enum `Option`
|
help: consider specifying the generic argument
|
199 | let record = class.call_method1("from_arrays", (py_arrays, None::<T>, py_schema))?;
|
|
@viirya fixed |
| @@ -196,7 +196,8 @@ impl PyArrowConvert for RecordBatch { | |||
|
|
|||
| let module = py.import("pyarrow")?; | |||
| let class = module.getattr("RecordBatch")?; | |||
| let record = class.call_method1("from_arrays", (py_arrays, py_schema))?; | |||
| let record = class | |||
| .call_method1("from_arrays", (py_arrays, None::<PyObject>, py_schema))?; | |||
There was a problem hiding this comment.
Looking at the change it looks like they want clients to use explicit named arguments in future, perhaps we should do so? https://pyo3.rs/v0.15.1/python_from_rust#creating-keyword-arguments. Maybe something for a follow up PR
|
Benchmark runs are scheduled for baseline = 56dfad0 and contender = 40837a8. 40837a8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3543
Rationale for this change
Pyarrow has changed its function signature and warns if the function is called in old way. https://github.com/apache/arrow/blob/85b167c05c2f93a95b23e8ac4fd4da576ea5b899/python/pyarrow/table.pxi#L2496-L2502
I update the function call of
from_arraysin RecordBatch'sto_pyarrowto fix it.What changes are included in this PR?
Change the arguments of pyarrow function call
Are there any user-facing changes?
No