Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parquet Avoid Reading 8 Byte Footer Twice from AsyncRead #3550

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Parquet Avoid Reading 8 Byte Footer Twice from AsyncRead #3550

merged 3 commits into from
Jan 18, 2023

Conversation

Sach1nAgarwal
Copy link
Contributor

Effect in performance increase

@Sach1nAgarwal
parquet:: avoid reading extra 8 bytes
6cd57a4 
Effect in increasing performance
@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 18, 2023
tustvold
tustvold approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this can be further simplified

@tustvold tustvold merged commit 96831de into apache:master Jan 18, 2023
@tustvold tustvold changed the title parquet:: avoid reading extra 8 bytes Parquet Avoid Reading 8 Byte Footer Twice from AsyncRead Jan 18, 2023
@ursabot
Copy link

ursabot commented Jan 18, 2023

Benchmark runs are scheduled for baseline = 14545a4 and contender = 96831de. 96831de is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Sach1nAgarwal Sach1nAgarwal deleted the parquet branch January 19, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sach1nAgarwal @ursabot @tustvold