-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArrayAccessor, Iterator, Extend and benchmarks for RunArray #3603
Conversation
Benchmark result for Edit: Updated benchmarks from host with 4 cores.
|
Benchmark result for binary search based The benchmark test definition is in https://github.com/askoa/arrow-rs/blob/run-extra-bench/arrow/benches/primitive_run_accessor.rs
|
I intend to review this early next week, apologies for the delay, it is hard for me to find time to review large PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some minor nits. Thank you
Thank you again |
Benchmark runs are scheduled for baseline = 79bda7d and contender = 25e10dd. 25e10dd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3520
Rationale for this change
See issue description.
What changes are included in this PR?
Extend
for thePrimitiveRunBuilder
andGenericByteRunBuilder
TypedRunArray
RunArrayIter
andArrayAccessor
forTypedRunArray
StringRunBuilder
Are there any user-facing changes?
Users will get new features for RunArray.
No breaking changes.