fix: take_run benchmark parameter #3679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I recently noticed an issue with the parameters in the benchmark
primitive_run_take
. The benchmark was not taking indices across the entire logical array but rather constrained to the length of take array. I updated the parameters to take indices across the entire logical array. There is performance regression because more values are taken from the array. I have furnished the performance differences belowBenchmark results
What changes are included in this PR?
Are there any user-facing changes?