Deprecate Array::data_ref (#3880) #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 23, 2023
| .validate_decimal_precision(array.precision()) | ||
| .unwrap_err(); | ||
|
|
||
| let array = Decimal128Array::from(vec![123456_i128]); |
There was a problem hiding this comment.
This test dates from before decimals were just a PrimitiveArray - we've come a long way in terms of ergonomics 😅
tustvold
force-pushed
the
deprecate-array-data-ref
branch
from
2801ce8 to
12ee185
Compare
tustvold
force-pushed
the
deprecate-array-data-ref
branch
from
12ee185 to
71be2e7
Compare
tustvold
commented
Mar 23, 2023
| @@ -3502,14 +3495,13 @@ where | |||
|
|
|||
| // wrap up | |||
| let builder = ArrayData::builder(out_dtype) | |||
| .offset(array.offset()) | |||
There was a problem hiding this comment.
Unlike before using value_offsets takes into account any offset
alamb
approved these changes
Mar 28, 2023
| @@ -3484,14 +3484,7 @@ where | |||
| _ => unreachable!(), | |||
| }; | |||
|
|
|||
| // Safety: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3880
Rationale for this change
Continues the process of gradually removing the need for arrays to store
ArrayDatadirectlyWhat changes are included in this PR?
Are there any user-facing changes?