Cleanup row count handling in JSON writer #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 24, 2023
| @@ -424,9 +401,10 @@ pub fn record_batches_to_json_rows( | |||
| let mut base = 0; | |||
| for batch in batches { | |||
| let row_count = batch.num_rows(); | |||
| let row_slice = &mut rows[base..base + batch.num_rows()]; | |||
There was a problem hiding this comment.
This is the change that enables removing row_count, it doesn't appear to be used elsewhere
tustvold
commented
Mar 24, 2023
| } | ||
| DataType::Dictionary(_, value_type) => { | ||
| let slice = array.slice(0, row_count); |
There was a problem hiding this comment.
This slice was redundant, the row count would always match the array length
crepererum
approved these changes
Mar 30, 2023
viirya
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Passing a row count limit down to the reader in this way is deeply confusing, and causes bugs such as #3924
What changes are included in this PR?
Are there any user-facing changes?