Make arrow_json::ReaderBuilder method names consistent #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 28, 2023
| /// Sets if the decoder should coerce primitive values (bool and number) into string when the Schema's column is Utf8 or LargeUtf8. | ||
| /// Sets if the decoder should coerce primitive values (bool and number) into string | ||
| /// when the Schema's column is Utf8 or LargeUtf8. | ||
| #[deprecated(note = "Use with_coerce_primitive")] |
There was a problem hiding this comment.
I recommend adding a "since=34.0.0" tag here so we know when we can remove them
There was a problem hiding this comment.
I personally think the git history is more useful for this, but if you feel strongly...
There was a problem hiding this comment.
I find it non trivial to match a git sha with a release number -- but I don't have a strong opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We tend to use the
withprefix for builder method names across arrow-csv, arrow-json and parquet. This helps to distinguish between constructor methods, and methods that return the currently set values.What changes are included in this PR?
Are there any user-facing changes?