Don't Duplicate Offset Index on RowGroupMetadata #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 26, 2023
| @@ -999,29 +1004,9 @@ mod tests { | |||
| requests: Default::default(), | |||
| }; | |||
|
|
|||
| let options = ArrowReaderOptions::new().with_page_index(true); | |||
There was a problem hiding this comment.
This was just a copy-paste of the test above and was unnecessary, so I opted to just remove it
tustvold
commented
Apr 26, 2023
| @@ -132,13 +132,25 @@ impl ParquetMetaData { | |||
| } | |||
|
|
|||
| /// Returns page indexes in this file. | |||
| #[deprecated(note = "Use Self::column_index")] | |||
| pub fn page_indexes(&self) -> Option<&ParquetColumnIndex> { | |||
There was a problem hiding this comment.
These accessors were very confusingly named, so I opted to rename them for clarity
crepererum
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4090
Rationale for this change
Noticed this whilst working on #4090, it is peculiar to be storing a subset of the page index on
RowGroupMetadatain addition to at the top-level onParquetMetadata. An argument could perhaps be made for storing the offset and column indices at theColumnChunkMetadatalevel, but duplicating it at the top-level and the row group level is confusing and does not seem to be necessary.What changes are included in this PR?
Are there any user-facing changes?