Better flight SQL example codes #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
|
I profiled the test case |
Oh, it's due to TcpNoDelay, it's not enabled. databendlabs/databend#11252 |
tustvold
approved these changes
Apr 27, 2023
| { | ||
| let addr = "127.0.0.1:50051"; | ||
|
|
||
| // We would just listen on TCP, but it seems impossible to know when tonic is ready to serve |
There was a problem hiding this comment.
Suggested change
| // We would just listen on TCP, but it seems impossible to know when tonic is ready to serve |
I believe the sleep below is to handle this
| .serve(addr.parse().unwrap()); | ||
|
|
||
| let request_future = async { | ||
| sleep(Duration::from_millis(2000)).await; |
There was a problem hiding this comment.
Suggested change
| sleep(Duration::from_millis(2000)).await; | |
| // wait for server to start up | |
| sleep(Duration::from_millis(2000)).await; |
| F: FnOnce(FlightSqlServiceClient<Channel>) -> C, | ||
| C: Future<Output = ()>, | ||
| { | ||
| let addr = "127.0.0.1:50051"; |
There was a problem hiding this comment.
#4145 shows how this could be adapted to not need to hard-code a port
arrow-flight/Cargo.toml
Outdated
| @@ -34,17 +34,37 @@ arrow-cast = { workspace = true } | |||
| arrow-ipc = { workspace = true } | |||
| arrow-schema = { workspace = true } | |||
| base64 = { version = "0.21", default-features = false, features = ["std"] } | |||
| tonic = { version = "0.9", default-features = false, features = ["transport", "codegen", "prost"] } | |||
| tonic = { version = "0.9", default-features = false, features = [ | |||
There was a problem hiding this comment.
I personally find this formatting harder to read...
|
Working on updating this |
|
Thank you for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Provide more detail examples and test codes for flight SQL.
What changes are included in this PR?
Are there any user-facing changes?