Deffered Object Store Config Parsing (#4191) #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
deferred-object-store-config
branch
from
db13f79 to
a6b73b1
Compare
tustvold
force-pushed
the
deferred-object-store-config
branch
from
a6b73b1 to
26be298
Compare
roeap
approved these changes
May 10, 2023
Comment on lines
+51
to
+55
| pub enum ClientConfigKey { | ||
| /// Allow non-TLS, i.e. non-HTTPS connections | ||
| AllowHttp, | ||
| } | ||
|
|
There was a problem hiding this comment.
Some users in delta-rs are asking to expose more client options on the python side, for this having some more keys defined might be helpful. Do you think this is something object_store wants to do in a follow-up?
There was a problem hiding this comment.
Do you think this is something object_store wants to do in a follow-up
Yes, 100%
There was a problem hiding this comment.
#4202 is the next step in exposing client options to the python side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4191
Rationale for this change
This closes #4191 whilst also making me happier that the current pattern is workable to support things like durations which need fallible parsing, etc...
What changes are included in this PR?
Are there any user-facing changes?