Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of RecordBatchReader for CSV reader #4195

Merged
merged 1 commit into from
May 10, 2023

Conversation

alexandreyc
Copy link
Contributor

Which issue does this PR close?

There's no issue associated with this PR. I can create one if needed.

Rationale for this change

Implementations of RecordBatchReader for JSON, IPC and Parquet exist but not for CSV...

What changes are included in this PR?

Implementation of RecordBatchReader for arrow_csv::reader::BufReader.

Are there any user-facing changes?

No breaking changes are introduced with this PR and no documentation need to be added or updated.

@alexandreyc alexandreyc force-pushed the csv-record-batch-reader branch from 400a023 to 733b459 Compare May 10, 2023 15:55
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 10, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@tustvold tustvold merged commit adca63a into apache:master May 10, 2023
@alexandreyc alexandreyc deleted the csv-record-batch-reader branch May 15, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants