Only increment metrics for data pages #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
added
the
development-process
alamb
approved these changes
May 26, 2023
| @@ -765,10 +764,7 @@ impl<'a, W: Write> PageWriter for SerializedPageWriter<'a, W> { | |||
| spec.compressed_size = compressed_size + header_size; | |||
| spec.offset = start_pos; | |||
| spec.bytes_written = self.sink.bytes_written() as u64 - start_pos; | |||
| // Number of values is incremented for data pages only | |||
There was a problem hiding this comment.
So what I am seeing is that this was basically a workaround for the fact that num_values was not updated for data pages in update_metrics_for_page which has now been fixed. If so that makes sense to me
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Split out from #4280
Previously SerializedPageWriter contained logic to only include data page in the num_values for the reported PageWriteSpec. This was not replicated in TestPageWriter (used solely for testing) and led to a behaviour mismatch. Lifting this into GenericColumnWriter eliminates this inconsistency but leads to some test changes
What changes are included in this PR?
Are there any user-facing changes?