Make GenericColumnWriter Send #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
make-column-writer-send
branch
from
b827f67 to
b3436de
Compare
tustvold
force-pushed
the
make-column-writer-send
branch
from
b3436de to
031ed98
Compare
viirya
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4286
Rationale for this change
This is the simple solution to #4286. The downside of this is it prevents the usage of non-Send Write, however, avoiding this would involve not using trait objects and instead plumbing the generics through. I'll continue to explore this, but I suspect the simple solution is the best option.
What changes are included in this PR?
Are there any user-facing changes?