feat(flight): support int32_to_int32_list_map in sql infos #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
roeap
changed the title
|
Thank you @roeap -- this is amazing! |
alamb
approved these changes
May 30, 2023
arrow-flight/src/sql/sql_info.rs
Outdated
| @@ -280,6 +348,22 @@ impl SqlInfoUnionBuilder { | |||
| /// let batch = info_list.encode().unwrap(); | |||
| /// ``` | |||
| /// | |||
| /// # Example | |||
There was a problem hiding this comment.
This seems to be identical to the example above. Is that intended? -- I wonder if it got added accidentally during merge 🤔
There was a problem hiding this comment.
Yes, I did a rebase, and this is likely an artefact of that! Sorry for missing that, will fix :)
There was a problem hiding this comment.
albeit repetition sometimes being helpful to learn things, went back to a single instance of the example 🤣.
| @@ -386,6 +474,15 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_sql_infos() { | |||
| let mut convert: HashMap<i32, Vec<i32>> = HashMap::new(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it depends on #4293 by @alamb, which contains tests useful to validate this implementation.Which issue does this PR close?
Closes #.
Rationale for this change
Thus far the SqlInfo helpers in arrow-flight did not yet support complex types defined in the specs in the form of
Map<i32, List<i32>>. This PR adds support for these types.What changes are included in this PR?
int32_to_int32_list_maptype in SqlInfo dense unionAre there any user-facing changes?
Users can now specify SqlInfos with the Map of i32 Lists type.