fix date conversion if timestamp below unixtimestamp #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
May 31, 2023
tustvold
reviewed
May 31, 2023
tustvold
reviewed
May 31, 2023
tustvold
reviewed
May 31, 2023
tustvold
reviewed
May 31, 2023
|
Thanks @tustvold I will address the comments. Probably we need to review all tests for cast and use new syntax instead of downcast? |
| @@ -1853,7 +1853,7 @@ pub fn cast_with_options( | |||
| if time_array.is_null(i) { | |||
| b.append_null(); | |||
| } else { | |||
| b.append_value((time_array.value(i) / from_size) as i32); | |||
| b.append_value(num::integer::div_floor::<i64>(time_array.value(i), from_size) as i32); | |||
There was a problem hiding this comment.
Something like
let pre_epoch_adjustment = if value(i) < 0 { -1 } else { 0 };
b.append_value(pre_epoch_adjustment + (time_array.value(i) / from_size) as i32);
might be faster (because it skips all the check made by div_floor) ?
There was a problem hiding this comment.
If you look at the implementation of div floor, that is what it is implemented as
There was a problem hiding this comment.
Can this convo be resolved then?
There was a problem hiding this comment.
@tustvold you'er right. My ide led me to the BigInt implementation of div_floor which is necessarily more complex, but not relevant here.
tustvold
approved these changes
May 31, 2023
tustvold
reviewed
May 31, 2023
| @@ -9172,4 +9172,41 @@ mod tests { | |||
| ); | |||
| assert!(casted_array.is_err()); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_cast_below_unixtimestamp() { | |||
There was a problem hiding this comment.
I confirmed this test fails on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4211 .
Rationale for this change
Fix date conversion if timestamp below unixtimestamp
What changes are included in this PR?
Are there any user-facing changes?
No